Add doorbell #30
Open
Add doorbell #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirizaki
requested changes
Jun 13, 2020
gateway/Automation/Automation.hpp
Outdated
| @@ -82,6 +82,10 @@ void kitchenOff() { | |||
| setOutput(KITCHEN_TABLE_ID, Relay::OFF); | |||
| } | |||
|
|
|||
| void doorbellclick() { | |||
There was a problem hiding this comment.
Let’s use camelCase naming with callback for callback functions, ie:
‘doorbellClickCallback’
gateway/Automation/Automation.hpp
Outdated
| @@ -82,6 +82,10 @@ void kitchenOff() { | |||
| setOutput(KITCHEN_TABLE_ID, Relay::OFF); | |||
| } | |||
|
|
|||
| void doorbellclick() { | |||
| dzwonek=1; | |||
There was a problem hiding this comment.
For enumerated values Enum can be proposed based on CPP code style guidelines:
‘’’
enum DoorBellState
{
DISABLED = 0,
ENABLED = 1,
SWITCHED = 2,
}
‘’’
See ‘Relay’ enum.
gateway/gateway.ino
Outdated
| @@ -15,6 +15,8 @@ | |||
| #define MY_BAUD_RATE 115200 | |||
| #endif | |||
|
|
|||
| uint8_t dzwonek = 0; | |||
There was a problem hiding this comment.
Prefer English language for variable names: ‘doorbellState‘
gateway/Automation/Automation.hpp
Outdated
| @@ -120,4 +124,6 @@ void setupButtons() { | |||
| workshop.attachClick(clickCallback, WORKSHOP_ID); | |||
|
|
|||
| corridor.attachClick(clickCallback, CORRIDOR_ID); | |||
|
|
|||
| doorbell.attachPressStart(doorbellclick); | |||
There was a problem hiding this comment.
Please use camelCase for callback as mentioned above.
gateway/gateway.ino
Outdated
| @@ -71,6 +73,21 @@ void loop() { | |||
| kitchenTable.tick(); | |||
| workshop.tick(); | |||
| corridor.tick(); | |||
| doorbell.tick(); | |||
|
|
|||
| switch (dzwonek) { | |||
There was a problem hiding this comment.
- Switch can be encapsulated in function (ie: ‘updateDoorbellState’) to avoid too long implementation of ‘loop’ and additionally it will automatically explain it’s purpose.
- As the current code doesn’t have any validation in any other places, it’s good practice to add implementation of default behaviour, even if it will never fall into it and there will be only ‘break’ instruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes tested and working ok.